ENH: store confound timeseries data #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that Also, not sure what to make of the failing T1w test. The values are close. Has something recently been modified that would change numerical precision? |
|
I would rebase on the latest master, which is linting clean. Then you should only have issues in your code to address. |
psadil
force-pushed
the
enh/store-qc-timeseries
branch
from
c20b408
to
c6fab96
Compare
psadil
changed the title
effigies
reviewed
Dec 5, 2023
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
reviewed
Dec 5, 2023
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
|
Thanks for the speedy review! I don't think that the ci/circleci T1w failure is related to this pull request, but let me know if I should look into it as a part of this. |
effigies
approved these changes
Dec 5, 2023
|
No, that's unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #992
The timeseries data are stored in a tsv file matching
[input_bids]_timeseries.tsv, with an accompanying json sidecar[input_bids]_timeseries.jsonColumns contain 6 motion parameters, DVARS, AFNI’s outlier ratio, and AFNI’s quality index
(Sorry that this took so long to push through!)